opt(reindex): do not try building indices when inserting a new predicate #7109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @martinmr)
|
✔️ Deploy preview for dgraph-docs ready! 🔨 Explore the source changes: 0bce607 🔍 Inspect the deploy logs: https://app.netlify.com/sites/dgraph-docs/deploys/5ff8120ec5b2ec000716f9ab 😎 Browse the preview: https://deploy-preview-7109--dgraph-docs.netlify.app |
jarifibrahim
approved these changes
Mar 10, 2021
aman-bansal
pushed a commit
that referenced
this pull request
Mar 15, 2021
…ate (#7109) When inserting a new predicate, do not perform rebuilding indices operations. Though the rebuilding and drop operation would be a NOOP. It is still better not to do extra stuff like creating tmp DBs(used for indexing), blocking writes etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting a new predicate, do not perform rebuilding indices operations. Though the rebuilding and drop operation would be a NOOP. It is still better not to do extra stuff like creating
tmpDBs(used for indexing), blocking writes etc.This change is