Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): Remove github issues link from the error messages. (#6036) #6183

Merged

Conversation

JatinDev543
Copy link
Contributor

@JatinDev543 JatinDev543 commented Aug 13, 2020

Since we don't use GitHub issues anymore, error messages should not link to them. Updating the error messages to say so.


This change is Reviewable

Docs Preview: Dgraph Preview

Since we don't use GitHub issues anymore, error messages should not link to them. Updating the error messages to say so.
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Aug 13, 2020
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)

@JatinDev543 JatinDev543 merged commit 4306349 into release/v20.07 Aug 14, 2020
@JatinDev543 JatinDev543 deleted the pawan/cherry-pick-removeGithubIssueLinkFromErrors branch August 14, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants