Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): Dgraph directive with reverse edge should work smoothly with interfaces (#5911) #5982

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Jul 14, 2020

Fixes #5744 and GRAPHQL-558

There was another bug where field which map to reverse edges in Dgraph where generated as part of AddTypeInput and TypeRef. They have been excluded now as we can't perform a mutation along them. They would earlier have given an error at runtime while doing mutations in Dgraph about predicate being incorrect because it starts with ~. Apart, from that to fix #5744, we also allow interfaces implemented by the current type in the check.

(cherry picked from commit ecec071)


This change is Reviewable

Docs Preview: Dgraph Preview

… with interfaces (#5911)

Fixes #5744

There was another bug where field which map to reverse edges in Dgraph where generated as part of AddTypeInput and TypeRef. They have been excluded now as we can't perform a mutation along them. They would earlier have given an error at runtime while doing mutations in Dgraph about predicate being incorrect because it starts with ~. Apart, from that to fix #5744, we also allow interfaces implemented by the current type in the che

(cherry picked from commit ecec071)
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Jul 14, 2020
@parasssh parasssh merged commit fc8104e into release/v20.07 Jul 14, 2020
@pawanrawal pawanrawal deleted the pawanrawal/cherrypick-5744 branch July 31, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants