Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GraphQL): Allow query of deleted nodes. (#5706) #5949

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

arijitAD
Copy link

@arijitAD arijitAD commented Jul 13, 2020

Fixes #GRAPHQL-491 (Release Blocker)
Allows delete mutation requests to query the deleted objects.
Now delete payload looks as following:

type deleteTodoPayload {
todo(...filter, page...etc) : [Todo]
msg: String
numUids: Int
}

(cherry picked from commit f29c5bb)


This change is Reviewable

Docs Preview: Dgraph Preview

Allows delete mutation requests to query the deleted objects.
Now delete payload looks as following:

type deleteTodoPayload {
  todo(...filter, page...etc) : [Todo]
  msg: String
  numUids: Int
}

(cherry picked from commit f29c5bb)
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Jul 13, 2020
@parasssh
Copy link
Contributor

Per Slack discussions with @lgalatin @shekarm , allowing this in even though it is not a release blocker because the GRAPHQL-427, which is a release blocker, depends on this.

Copy link
Contributor

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: since it is a cherry pick and no conflicts per @arijitAD

Reviewable status: 0 of 40 files reviewed, all discussions resolved (waiting on @MichaelJCompton and @pawanrawal)

@parasssh parasssh merged commit 6418421 into release/v20.07 Jul 13, 2020
@arijitAD arijitAD deleted the arijitAD/20.07_del-query-updated branch July 13, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants