release/v20.03 - Alpha: Gracefully shutdown ludicrous mode (#5561) #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes - DGRAPH-1353 When live loader in running on an Alpha in ludicrous mode, alpha will crash with a segmentation fault error because badger was closed before ludicrous mode goroutines were stopped. This PR fixed that issue. The crash can be reproduced by ``` 1. dgraph zero --ludicrous_mode 2. dgraph alpha --ludicrous_mode --enable_sentry=false 3. dgraph live -f $GOPATH/src/github.com/dgraph-io/benchmarks/data/21million.rdf.gz \ -s $GOPATH/src/github.com/dgraph-io/benchmarks/data/21million.schema \ -z localhost:5080 -a localhost:9080 --ludicrous_mode Hit <CTRL+C> while alpha is receiving data from live loader. ``` (cherry picked from commit e326b9e)
pawanrawal
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - DGRAPH-1353
When live loader in running on an Alpha in ludicrous mode, alpha will
crash with a segmentation fault error because badger was closed before
ludicrous mode goroutines were stopped. This PR fixed that issue.
The crash can be reproduced by
(cherry picked from commit e326b9e)
This change is
Docs Preview: