Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql: Fix mutation on predicate with special characters having dgr… #5577

Merged
merged 2 commits into from
Jun 8, 2020
Merged

graphql: Fix mutation on predicate with special characters having dgr… #5577

merged 2 commits into from
Jun 8, 2020

Conversation

arijitAD
Copy link

@arijitAD arijitAD commented Jun 4, 2020 •
edited by dgraph-bot
Loading

…aph directive. (#5526)

  • Fix Dgraph directive for multiple languages.

(cherry picked from commit 92232c0)

This change is Reviewable

Docs Preview: Dgraph Preview

graphql: Fix mutation on predicate with special characters having dgr…
c1d94b8 
…aph directive. (#5526)

* Fix Dgraph directive for multiple language.

(cherry picked from commit 92232c0)
@arijitAD arijitAD requested review from manishrjain and a team as code owners June 4, 2020 16:52
pawanrawal
pawanrawal approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)

@arijitAD arijitAD merged commit 829cbb0 into release/v20.03 Jun 8, 2020
arijitAD pushed a commit that referenced this pull request Jul 6, 2020
graphql: Fix mutation on predicate with special characters having dgr… (
9a318fa 
#5577)

* graphql: Fix mutation on predicate with special characters having dgraph directive. (#5526)

* Fix Dgraph directive for multiple languages.

(cherry picked from commit 92232c0)
(cherry picked from commit 829cbb0)
@arijitAD arijitAD mentioned this pull request Jul 6, 2020
Closed
@joshua-goldstein joshua-goldstein deleted the arijitAD/predicate-fix-20.03 branch August 11, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanrawal pawanrawal pawanrawal approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@MichaelJCompton MichaelJCompton Awaiting requested review from MichaelJCompton

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arijitAD @pawanrawal