backport: graphql: Minor delete mutation msg fix (#5316) #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the delete msg reported for the case when no nodes are deleted to No nodes were deleted. In addition, it corrects some tests which were wrong earlier. Fixes #GRAPHQL-423. Co-authored-by: Abhimanyu Singh Gaur <[email protected]> (cherry picked from commit 47f2f51) # Conflicts: # ee/acl/acl_test.go # graphql/e2e/auth/auth_test.go # graphql/e2e/common/mutation.go # graphql/resolve/mutation.go
abhimanyusinghgaur
changed the title
MichaelJCompton
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the delete msg reported for the case when no nodes are deleted to
No nodes were deleted. In addition, it corrects some tests which were wrong earlier.Fixes #GRAPHQL-465.
(cherry picked from commit 47f2f51)
# Conflicts:
# ee/acl/acl_test.go
# graphql/e2e/auth/auth_test.go
# graphql/e2e/common/mutation.go
# graphql/resolve/mutation.go
This change is
Docs Preview: