Replace shutdownCh and wait groups to a y.Closer for shutting down Alpha #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanrawal
requested review from
manishrjain,
MichaelJCompton and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
|
Can't we use y.Closer instead of shutdown channel? |
jarifibrahim
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
pawanrawal
changed the title
manishrjain
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton and @vvbalaji-dgraph)
martinmr
pushed a commit
that referenced
this pull request
Jul 2, 2020
…pha (#5560) Earlier we had worker.ShutdownCh which was used to pass information between alpha/run.go and graphql/admin.go which was causing confusion and was being used to stop the worker itself. We now have a y.Closer in graphql/admin which manages the WaitGroup and passing of signals between goroutines using channels. Fixes DGRAPH-1169
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
…pha (hypermodeinc#5560) Earlier we had worker.ShutdownCh which was used to pass information between alpha/run.go and graphql/admin.go which was causing confusion and was being used to stop the worker itself. We now have a y.Closer in graphql/admin which manages the WaitGroup and passing of signals between goroutines using channels. Fixes DGRAPH-1169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we had
worker.ShutdownChwhich was used to pass information betweenalpha/run.goandgraphql/admin.gowhich was causing confusion and was being used to stop the worker itself. We now have ay.Closeringraphql/adminwhich manages the WaitGroup and passing of signals between goroutines using channels.Fixes DGRAPH-1169
This change is