Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Add more validations for coercion of object/scalar and vice versa #5534

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented May 28, 2020

Fixes GRAPHQL-383


This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label May 28, 2020
@pawanrawal pawanrawal marked this pull request as ready for review June 1, 2020 16:01
Copy link
Contributor

@MichaelJCompton MichaelJCompton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur and @MichaelJCompton)

Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur)

@pawanrawal pawanrawal merged commit 8e7a444 into master Jun 2, 2020
@pawanrawal pawanrawal deleted the pawanrawal/graphql-383 branch June 2, 2020 07:07
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

3 participants