Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Queries or mutations shouldn't be part of generated Dgraph schema #5524

Merged
merged 1 commit into from
May 29, 2020

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented May 27, 2020

I observed from the logs that this was happening, which is unexpected behavior. Fixes GRAPHQL-482.


This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label May 27, 2020
@pawanrawal pawanrawal changed the title Queries or mutations shouldn't be part of generated Dgraph schema graphql: Queries or mutations shouldn't be part of generated Dgraph schema May 27, 2020
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Missed it earlier. Thanks Pawan.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)

Copy link
Contributor

@MichaelJCompton MichaelJCompton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)

@pawanrawal pawanrawal merged commit adf690c into master May 29, 2020
@pawanrawal pawanrawal deleted the pawanrawal/graphql-482 branch May 29, 2020 07:44
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

3 participants