Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Fix non-unique schema issue (#5054) #5481

Merged
merged 1 commit into from
May 20, 2020

Conversation

harshil-goel
Copy link
Contributor

@harshil-goel harshil-goel commented May 20, 2020

Fixes #GRAPHQL-337

During the time, when alpha's admin server was waiting for Dgraph cluster to boot up, if someone sent a GraphQL schema update request, it would create a new node for GQLSchema in Dgraph. This PR resolves this problem. From now on, there will only be one node of type dgraph.graphql ever in dgraph.

(cherry picked from commit 8a650d7, 401e052, 85bd30c)


This change is Reviewable

Docs Preview: Dgraph Preview

Fixes #GRAPHQL-337

During the time, when alpha's admin server was waiting for Dgraph cluster to boot up, if someone sent a GraphQL schema update request, it would create a new node for GQLSchema in Dgraph. This PR resolves this problem. From now on, there will only be one node of type `dgraph.graphql` ever in dgraph.

(cherry picked from commit 8a650d7, 401e052, 85bd30c)
@harshil-goel harshil-goel requested review from manishrjain and a team as code owners May 20, 2020 05:00
@harshil-goel harshil-goel merged commit 75a0487 into release/v20.03 May 20, 2020
@harshil-goel harshil-goel deleted the harshil-goel/release20-2 branch May 20, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants