-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ludicrous mode to live loader #5419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arijitAD, @gja, and @manishrjain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arijitAD, @gja, and @manishrjain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that this should only be done if Alpha is under ludicrous mode.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gja)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment that doesn't need to be addressed in this PR, but is there a way to verify that the alpha is in fact in ludicrous mode (the health endpoint perhaps) and exiting if that's not the case.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gja)
* Adds ludicrous mode to live loader * changed msg (cherry picked from commit 02c90d2)
* Adds ludicrous mode to live loader * changed msg
Introduces ludicrous mode to live loader. It significantly reduces the memory utilized by live loader, and marginally increases ingestion speed.
This change is