Worker: Return nil on error #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 9, 2020 12:33
This reverts commit 24e7284.
jarifibrahim
changed the title
jarifibrahim
requested review from
manishrjain,
pawanrawal and
a team
as code owners
pawanrawal
approved these changes
May 11, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
manishrjain
approved these changes
May 11, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
The following output from pprof shows that the `pb.Result{}` takes
up a lot of memory. This PR tries to reduce the unnecessary allocation.
From https://discuss.dgraph.io/t/optimize-dgraph-memory-usage/6665
```
(pprof) list processTask
. 1.91GB 887: out, err := qs.helpProcessTask(ctx, q, gid)
. . 888: if err != nil {
4.50MB 4.45GB 889: return &pb.Result{}, err
. . 890: }
. 4.97GB 891: return out, nil
. . 892:}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following output from pprof shows that the
pb.Result{}takes up a lot of memory. This PR tries to reduce the unnecessary allocationFrom https://discuss.dgraph.io/t/optimize-dgraph-memory-usage/6665
This change is