Use pre-allocated protobufs during backups. #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backups convert the values stored in disk into an intermediate format (for backwards compatibility reasons). This creates a lot of pb.PostingList and pb.BackupPostingList objects that are discarded almost immediatly. Using a sync.Pool to allocate these objects should reduce the amount of memory that is allocated during a backup.
martinmr
changed the title
manishrjain
approved these changes
May 22, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr and @vvbalaji-dgraph)
worker/backup_processor.go, line 298 at r1 (raw file):
pl := pr.plList[threadNum] bpl := pr.bplList[threadNum] defer func() {
Remove defer here. Do the reset upfront.
martinmr
commented
May 22, 2020
There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @vvbalaji-dgraph)
worker/backup_processor.go, line 298 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Remove defer here. Do the reset upfront.
Done.
martinmr
added a commit
that referenced
this pull request
May 22, 2020
Backups convert the values stored in disk into an intermediate format (for backwards compatibility reasons). This creates a lot of pb.PostingList and pb.BackupPostingList objects that are discarded almost immediatly. Using preallocated protobufs (one per thread used by the stream object) should avoid these allocations altogether. Fixes DGRAPH-1312
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Backups convert the values stored in disk into an intermediate format (for backwards compatibility reasons). This creates a lot of pb.PostingList and pb.BackupPostingList objects that are discarded almost immediatly. Using preallocated protobufs (one per thread used by the stream object) should avoid these allocations altogether. Fixes DGRAPH-1312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backups convert the values stored in disk into an intermediate format
(for backwards compatibility reasons). This creates a lot of
pb.PostingList and pb.BackupPostingList objects that are discarded
almost immediately. Using preallocated protobufs (one per thread used by
the stream object) should avoid these allocations altogether.
Fixes DGRAPH-1312
This change is
Docs Preview: