Add a check to throw an error is a nil pointer is passed to unmarshalOrCopy #5334
Conversation
I am not sure how this happens because all I have is the stacktrace but it looks like unmarshalOrCopy is getting called with a nil plist. I am not sure how this happens because l.plist is being instantiated correctly. This PR is doing two things to fix this issue. 1. Create the posting list right before calling unmarshalOrCopy to make sure that a nil value is never passed. 2. Add a check to throw an error is a nil pointer is passed to unmarshalOrCopy. Fixes DGRAPH-1300
There was a problem hiding this comment.
This one looks like the system didn't have enough memory to do the posting list unmarshal. So, better to check with on Go slack and see what they think.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @martinmr and @parasssh)
posting/mvcc.go, line 233 at r1 (raw file):
Previously, parasssh wrote…
object -> posting list
I'd make the %s the last thing. Because hex.Dump can take multiple lines.
Maybe just do this, and change nothing else.
posting/mvcc.go, line 268 at r2 (raw file):
} l := &List{}
Avoid unnecessary changes.
posting/mvcc.go, line 297 at r2 (raw file):
return l, nil case BitCompletePosting: pl := &pb.PostingList{}
No need for this.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @manishrjain and @parasssh)
posting/mvcc.go, line 233 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
I'd make the %s the last thing. Because hex.Dump can take multiple lines.
Maybe just do this, and change nothing else.
Done.
posting/mvcc.go, line 268 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Avoid unnecessary changes.
Done.
posting/mvcc.go, line 297 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
No need for this.
Done.
martinmr
changed the title
This change is