/health endpoint now shows EE Features available #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2020 15:40
manishrjain
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @parasssh)
ee/utils_ee.go, line 41 at r1 (raw file):
var ee []string if len(worker.Config.HmacSecret) > 0 { ee = append(ee, acl)
if a const is being used exactly once, then directly use the value.
parasssh
commented
Apr 27, 2020
There was a problem hiding this comment.
Dismissed @manishrjain from a discussion.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @manishrjain)
ee/utils_ee.go, line 41 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
if a const is being used exactly once, then directly use the value.
Done.
parasssh
pushed a commit
that referenced
this pull request
Apr 27, 2020
(cherry-picked from commit 51f8cfb)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5234
Fixes DGRAPH-1268
The /health alpha endpoint now includes the EE Features that are enabled. For OSS builds this field will be absent since no EE Features are available.
As of now, the following EE Features are identified:
This change is