-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bulk-loader use-case to import unencrypted export and encrypt the result #5209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @parasssh)
dgraph/cmd/bulk/loader.go, line 120 at r1 (raw file):
writeTs: getWriteTimestamp(zero), } st.schema = newSchemaStore(readSchema(opt.SchemaFile, opt.BadgerKeyFile, opt.Encrypted), opt, st)
just pass in the opt object, instead of passing in individual arguments.
dgraph/cmd/bulk/run.go, line 109 at r1 (raw file):
" The key size indicates the chosen AES encryption (AES-128/192/256 respectively). "+ " This key is used to encrypt the output data directories and to decrypt the input "+ " schema and data files (if enncrytped). Enterprise feature.")
if encrypted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @manishrjain)
dgraph/cmd/bulk/loader.go, line 120 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
just pass in the opt object, instead of passing in individual arguments.
Done.
dgraph/cmd/bulk/run.go, line 109 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
if encrypted
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @manishrjain from 2 discussions.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)
… the result. (#5209) Fixes DGRAPH-1254
… the result. (hypermodeinc#5209) Fixes DGRAPH-1254
Fixes https://dgraph.atlassian.net/browse/DGRAPH-1254
This change is