GraphQL endpoints accept application/graphql content type #5125
Conversation
| default: | ||
| // https://graphql.org/learn/serving-over-http/#post-request says: | ||
| // "A standard GraphQL POST request should use the application/json | ||
| // content type ..." | ||
| return nil, errors.New( | ||
| "Unrecognised Content-Type. Please use application/json for GraphQL requests") | ||
| "Unrecognised Content-Type. Please use application/json or application/graphql for GraphQL requests") |
There was a problem hiding this comment.
Tested locally with
curl --request POST \
--url http://localhost:8080/admin \
--header 'content-type: application/graphql' \
--data-binary '@./graphql/fullbackup.graphql'
works fine.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gja, @manishrjain, @MichaelJCompton, and @pawanrawal)
…ation/graphql-to-graphql-endpoint
…ation/graphql-to-graphql-endpoint
| @@ -27,7 +27,7 @@ function restartCluster { | |||
| docker_compose_gopath=`pwd`/../osx-docker-gopath | |||
|
|
|||
| # FIXME: read the go version from a constant | |||
| docker run -it --rm \ | |||
| docker run --rm \ | |||
There was a problem hiding this comment.
I removed -it. I think in a previous commit i put -it, though this isn't interactive
| @@ -442,6 +443,17 @@ func (params *GraphQLParams) ExecuteAsPost(t *testing.T, url string) *GraphQLRes | |||
| return params.Execute(t, req) | |||
| } | |||
|
|
|||
| // ExecuteAsPostApplicationGraphql builds an HTTP Post with type application/graphql | |||
| // Note, variables are not allowed | |||
| func (params *GraphQLParams) ExecuteAsPostApplicationGraphql(t *testing.T, url string) *GraphQLResponse { | |||
| return nil, err | ||
| } | ||
|
|
||
| func (params *GraphQLParams) buildPostRequest(url string, body []byte, contentType string) (*http.Request, error) { |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @gja, @manishrjain, and @MichaelJCompton)
graphql/web/http.go, line 200 at r2 (raw file):
return nil, errors.Wrap(err, "Could not read GraphQL request body") } gqlReq.Query = string(string(bytes))
Probably a typo, just need to have one string here.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @gja, @manishrjain, @MichaelJCompton, and @pawanrawal)
graphql/web/http.go, line 200 at r2 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
Probably a typo, just need to have one string here.
Done.
Description.
/graphql and /admin accepts "Content-Type: application/graphql "
NOTE: https://graphql.org/learn/serving-over-http/#post-request mentions that application/graphql should be treated as a graphql query the entire body being the query.
Changelog tags.
Please indicate if documentation needs to be updated.
Getting started examples should use this instead of the json endpoints
This change is
Docs Preview: