Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in Task FrameWork, fixes #5034 #5081

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix panic in Task FrameWork, fixes #5034 #5081

merged 1 commit into from
Apr 3, 2020

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Apr 2, 2020

This change is Reviewable

@mangalaman93 mangalaman93 requested review from manishrjain and a team as code owners April 2, 2020 09:25
@mangalaman93 mangalaman93 requested a review from parasssh April 2, 2020 09:25
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @parasssh)

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mangalaman93 mangalaman93 merged commit 8482527 into master Apr 3, 2020
@mangalaman93 mangalaman93 deleted the aman/5034 branch April 3, 2020 16:26
parasssh pushed a commit that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants