Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issue on 32 bit machine #4963

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Fix compilation issue on 32 bit machine #4963

merged 1 commit into from
Mar 24, 2020

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Mar 18, 2020

Also adds encryption for temporary badger used for indexing.

This change is Reviewable

Docs Preview: Dgraph Preview

@mangalaman93 mangalaman93 requested review from manishrjain, martinmr and a team as code owners March 18, 2020 15:23
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mangalaman93 and @martinmr)


posting/index.go, line 553 at r1 (raw file):

		WithCompression(options.None).
		WithEventLogging(false).
		WithLogRotatesToFlush(10)

if encryption is enabled, add here as well perhaps.


x/x.go, line 89 at r1 (raw file):

	// to the max grpc frame size). Users will still need to set the max
	// message sizes allowable on the client size when dialing.
	GrpcMaxSize = 2 << 30

I think 2^32 - 1 might work on 32-bit machines.

Copy link
Member Author

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)


posting/index.go, line 553 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

if encryption is enabled, add here as well perhaps.

Done.


x/x.go, line 89 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

I think 2^32 - 1 might work on 32-bit machines.

Done.

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Got a few comments.

Reviewed 6 of 6 files at r2.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @mangalaman93, @manishrjain, and @martinmr)


posting/index.go, line 552 at r2 (raw file):

		dbOpts.TableLoadingMode = options.MemoryMap
	case "ram":
		dbOpts.TableLoadingMode = options.LoadToRAM

Just use mmap.


posting/index.go, line 561 at r2 (raw file):

	switch x.WorkerConfig.BadgerVlog {
	case "mmap":
		dbOpts.ValueLogLoadingMode = options.MemoryMap

Just use mmap.


x/config.go, line 82 at r2 (raw file):

	LudicrousMode bool
	// BadgerTables is the name of the mode used to load the badger tables.
	BadgerTables string

Don't need this.


x/config.go, line 84 at r2 (raw file):

	BadgerTables string
	// BadgerVlog is the name of the mode used to load the badger value log.
	BadgerVlog string

Don't need this.

Copy link
Member Author

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @manishrjain and @martinmr)


posting/index.go, line 552 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Just use mmap.

Removed the option.


posting/index.go, line 561 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Just use mmap.

Removed the option.


x/config.go, line 82 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Don't need this.

Done.


x/config.go, line 84 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Don't need this.

Done.

@mangalaman93 mangalaman93 merged commit eebe1b7 into master Mar 24, 2020
@mangalaman93 mangalaman93 deleted the aman/32bit branch March 24, 2020 13:41
NamanJain8 added a commit that referenced this pull request Nov 20, 2020
This PR removes the cache and compression from indexing which is not present in master and other release branches but is somehow present in v1.2.
This change was made to master through #4963, but was not cherry-picked to v1.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants