-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation issue on 32 bit machine #4963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mangalaman93 and @martinmr)
posting/index.go, line 553 at r1 (raw file):
WithCompression(options.None). WithEventLogging(false). WithLogRotatesToFlush(10)
if encryption is enabled, add here as well perhaps.
x/x.go, line 89 at r1 (raw file):
// to the max grpc frame size). Users will still need to set the max // message sizes allowable on the client size when dialing. GrpcMaxSize = 2 << 30
I think 2^32 - 1 might work on 32-bit machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
posting/index.go, line 553 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
if encryption is enabled, add here as well perhaps.
Done.
x/x.go, line 89 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
I think 2^32 - 1 might work on 32-bit machines.
Done.
d70eef5
to
95a8d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @mangalaman93, @manishrjain, and @martinmr)
posting/index.go, line 552 at r2 (raw file):
dbOpts.TableLoadingMode = options.MemoryMap case "ram": dbOpts.TableLoadingMode = options.LoadToRAM
Just use mmap.
posting/index.go, line 561 at r2 (raw file):
switch x.WorkerConfig.BadgerVlog { case "mmap": dbOpts.ValueLogLoadingMode = options.MemoryMap
Just use mmap.
x/config.go, line 82 at r2 (raw file):
LudicrousMode bool // BadgerTables is the name of the mode used to load the badger tables. BadgerTables string
Don't need this.
x/config.go, line 84 at r2 (raw file):
BadgerTables string // BadgerVlog is the name of the mode used to load the badger value log. BadgerVlog string
Don't need this.
26ae022
to
07a7603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @manishrjain and @martinmr)
posting/index.go, line 552 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Just use mmap.
Removed the option.
posting/index.go, line 561 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Just use mmap.
Removed the option.
x/config.go, line 82 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Don't need this.
Done.
x/config.go, line 84 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Don't need this.
Done.
2342463
to
c340b43
Compare
This PR removes the cache and compression from indexing which is not present in master and other release branches but is somehow present in v1.2. This change was made to master through #4963, but was not cherry-picked to v1.2.
Also adds encryption for temporary badger used for indexing.
This change is
Docs Preview: