Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special characters in schema and type queries. #4937

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Mar 14, 2020

Special predicate names (i.e using Chinese characters) need to be
wrapped around "<" and ">" brackets but the lexer does not currently
support that. This PR adds support for that syntax.

Fixes #4933


This change is Reviewable

Special predicate names (i.e using Chinese characters) need to be
wrapped around "<" and ">" brackets but the lexer does not currently
support that. This PR adds support for that syntax.

Fixes #4933
@martinmr martinmr requested review from manishrjain and a team as code owners March 14, 2020 00:09
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 0872174 into master Mar 16, 2020
@martinmr martinmr deleted the martinmr/schema-special-chars branch March 16, 2020 19:49
martinmr added a commit that referenced this pull request Mar 17, 2020
Special predicate names (i.e using Chinese characters) need to be
wrapped around "<" and ">" brackets but the lexer does not currently
support that. This PR adds support for that syntax.

Fixes #4933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

I can't use '<>' in schema
2 participants