Split keys during backup restore. #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
manishrjain
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)
worker/restore.go, line 155 at r1 (raw file):
return 0, err } } else {
else if size > something { roll up } else { just write } // the last one would be the most common case.
In fact, the first if can do the last one as well.
martinmr
commented
Mar 16, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
worker/restore.go, line 155 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
else if size > something { roll up } else { just write } // the last one would be the most common case.
In fact, the first if can do the last one as well.
Done.
martinmr
added a commit
that referenced
this pull request
Mar 17, 2020
If the list is too big and is not split before writing it too disk, we could end up in the situation described in #4733. So the posting lists should be split before writing them to disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the list is too big and is not split before writing it too disk, we could end up in the situation
described in #4733. So the posting lists should be split before writing them to disk.
This change is
Docs Preview: