Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke "go tool pprof" instead of "pprof". #4536

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Invoke "go tool pprof" instead of "pprof". #4536

merged 1 commit into from
Jan 9, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Jan 9, 2020 •
edited
Loading

This change should eliminate the flakiness in this test in TeamCity
since not all agents have pprof installed directly but pprof can be
accessed via "go tool pprof".

Fixes #4536

This change is Reviewable

@martinmr
Invoke "go tool pprof" instead of "pprof".
06f804c 
This change should eliminate the flakiness in this test in TeamCity
since not all agents have pprof installed directly but pprof can be
accessed via "go tool pprof".
@martinmr martinmr requested a review from danielmai January 9, 2020 23:26
@martinmr martinmr requested a review from manishrjain as a code owner January 9, 2020 23:26
danielmai
danielmai approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai and @manishrjain)

danielmai
danielmai approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@martinmr martinmr merged commit 2851e2d into master Jan 9, 2020
@martinmr martinmr deleted the martinmr/pprof-size-test branch January 9, 2020 23:59
@martinmr martinmr mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmr @danielmai