Write group_id files to postings directories during restore. #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the restore command to write a group_id file containing the ID of the group to which the data belongs. This is the same mechanism used by the bulk loader to ensure alphas with data for reserved predicates are always assigned to the right group.
manishrjain
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the restore command to write a group_id file containing
the ID of the group to which the data belongs. This is the same
mechanism used by the bulk loader to ensure alphas with data for
reserved predicates are always assigned to the right group.
This change is