Acquire read lock instead of exclusive lock for langBaseCache. #4279
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @arijitAD, @balajijinnah, and @manishrjain)
tok/langbase.go, line 55 at r1 (raw file):
langBaseCache.Lock() defer langBaseCache.Unlock()
After aquiring lock check once again whether. cache contains the lang or not. Some other routine may update the value
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @balajijinnah and @manishrjain)
tok/langbase.go, line 55 at r1 (raw file):
Previously, balajijinnah (balaji) wrote…
After aquiring lock check once again whether. cache contains the lang or not. Some other routine may update the value
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)
|
@arijitAD Could this PR have impacted upsert performance? |
Reduces lock contention in langBaseCache by using RWMutex instead of Mutex.
This change is