Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify type definitions do not have duplicate fields. #3925

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Sep 5, 2019

Fixes #3924


This change is Reviewable

@martinmr martinmr requested review from manishrjain and a team as code owners September 5, 2019 21:30
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@martinmr you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me - functionality seems good and a test is added as well.


Reviewed with ❤️ by PullRequest

Copy link

@gitlw gitlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)

@martinmr martinmr merged commit 66e3670 into master Sep 6, 2019
@martinmr martinmr deleted the martinmr/fix-type-dup-fields branch September 6, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

A type can specify the same field multiple times
2 participants