Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor in badger, dgo and regenerate protobufs #3747

Merged
merged 3 commits into from
Aug 2, 2019
Merged

vendor in badger, dgo and regenerate protobufs #3747

merged 3 commits into from
Aug 2, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented Aug 2, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@gitlw gitlw requested review from manishrjain and a team as code owners August 2, 2019 20:04
martinmr
martinmr reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: for the vendor changes.

Not sure how we decided to handle the protobuf changes though, @danielmai would be the person to ask.

Reviewable status: 0 of 44 files reviewed, all discussions resolved (waiting on @manishrjain)

@gitlw gitlw merged commit e1071fe into master Aug 2, 2019
@gitlw gitlw deleted the gitlw/vendor_in_badger branch August 2, 2019 20:46
@mangalaman93 mangalaman93 mentioned this pull request Aug 2, 2019
Closed
@danielmai danielmai mentioned this pull request Aug 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmr martinmr martinmr left review comments

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitlw @martinmr