-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the stream framework to rebuild indices. #3686
Conversation
The stream framework can iterate over the index prefix keys concurrently whereas currently there's only one thread iterating over the keys. Changing to the stream framework should provide a speed up over the current approach.
The unit tests checking the rebuild process still pass. I manually checked that I could do full text queries after a rebuild with that index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @martinmr)
posting/index.go, line 502 at r2 (raw file):
stream := pstore.NewStreamAt(r.startTs) stream.Prefix = r.prefix
stream.LogPrefix = "Indexing..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
posting/index.go, line 502 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
stream.LogPrefix = "Indexing..."
I'll do this in the next PR to avoid having to wait for another round of teamcity tests. Added a task in asana to avoid forgetting this.
The stream framework can iterate over the index prefix keys concurrently
whereas currently there's only one thread iterating over the keys.
Changing to the stream framework should provide a speed up over the
current approach.
This change is