Add option to override credentials and use public buckets. #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the credentials are taken from environmental variables. This means any other location with different credentials won't work. This change gives the option to override the credentials or specify the location does not need credentials. This might be useful during emergencies or when the credentials changed and restarting Dgraph is not desirable.
manishrjain
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
mangalaman93
pushed a commit
that referenced
this pull request
Apr 10, 2019
Currently, the credentials are taken from environmental variables. This means any other location with different credentials won't work. This change gives the option to override the credentials or specify the location does not need credentials. This might be useful during emergencies or when the credentials changed and restarting Dgraph is not desirable.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…inc#3227) Currently, the credentials are taken from environmental variables. This means any other location with different credentials won't work. This change gives the option to override the credentials or specify the location does not need credentials. This might be useful during emergencies or when the credentials changed and restarting Dgraph is not desirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the credentials are taken from environmental variables. This
means any other location with different credentials won't work. This
change gives the option to override the credentials or specify the
location does not need credentials. This might be useful during
emergencies or when the credentials changed and restarting Dgraph is not
desirable.
I had to test this manually with a minio setup so no automated tests for now but
I am working on adding a minio endpoint to our testing environment.
This change is