Fix panic when deleting a user or group that does not exist #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
reviewed
Mar 27, 2019
There was a problem hiding this comment.
Depend on the interface function to determine if you have a valid entity or not.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @mangalaman93)
mangalaman93
approved these changes
Mar 27, 2019
added 2 commits
March 27, 2019 12:14
…ing up conversion
manishrjain
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a user or group that does not exist, the return variable of type AclEntity has a type, with a value of nil. In such a case, the variable is treated not being nil per https://golang.org/doc/faq#nil_error
This change is