Add --replace_out option to bulk command. #3089
Conversation
x/file.go
Outdated
| @@ -92,3 +93,30 @@ func FindDataFiles(str string, ext []string) []string { | |||
|
|
|||
| return list | |||
| } | |||
|
|
|||
| // IsMissingOrEmptyDir returns true if the path either does not exist or is a directory that is empty. | |||
dgraph/cmd/bulk/run.go
Outdated
| // Make sure it's OK to create or replace the directory specified with the --out option. | ||
| // It is always OK to create or replace the default output directory. | ||
| if opt.OutDir != defaultOutDir && !x.IsMissingOrEmptyDir(opt.OutDir) && !opt.ReplaceOutDir { | ||
| fmt.Fprintf(os.Stderr, "Output directory exists and is not empty." + |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
dgraph/cmd/bulk/run.go
Outdated
| // Make sure it's OK to create or replace the directory specified with the --out option. | ||
| // It is always OK to create or replace the default output directory. | ||
| if opt.OutDir != defaultOutDir && !x.IsMissingOrEmptyDir(opt.OutDir) && !opt.ReplaceOutDir { | ||
| fmt.Fprintf(os.Stderr, "Output directory exists and is not empty." + |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @codexnull)
x/file.go, line 105 at r3 (raw file):
} x.Check(err)
For better re-usability, I think it's better to return the err to the caller than crashing the program.
Except this, the PR looks good to me.
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @codexnull and @gitlw)
x/file.go, line 105 at r3 (raw file):
Previously, gitlw (Lucas Wang) wrote…
For better re-usability, I think it's better to return the err to the caller than crashing the program.
Except this, the PR looks good to me.
Good point. Fixed
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 2 of 2 files at r4.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @codexnull and @gitlw)
Fixes hypermodeinc#3034. Summary of changes: * Add --replace_out option to bulk command. * Require --replace_out option if * Output directory was changed from default, and * Output directory exists, and * Output directory is not empty
Don't blindly replace the bulk out directory if it already exists and contains data. Fixes #3034.
This change is