Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3011: ignore uids on import #3045

Merged
merged 6 commits into from
Feb 20, 2019

Conversation

codexnull
Copy link
Contributor

@codexnull codexnull commented Feb 20, 2019

Summary of changes:

  • Update bulk loader to preserve UIDs from load data by default to match live loader behavior.

  • Add --new_uids option to both live and bulk loaders to ignore UIDs in load data and assign new ones.

Fixes #3011.


This change is Reviewable

@codexnull codexnull requested a review from a team February 20, 2019 00:04
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also resolve the conflicts?

Reviewed 16 of 16 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @codexnull)


dgraph/cmd/live/run.go, line 102 at r1 (raw file):

	flag.BoolP("use_compression", "C", false,
		"Enable compression on connection to alpha server")
	flag.Bool("new_uids", false, ""+

Is the plus sign a typo?

Copy link
Contributor Author

@codexnull codexnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Reviewable status: 13 of 16 files reviewed, 1 unresolved discussion (waiting on @martinmr)


dgraph/cmd/live/run.go, line 102 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

Is the plus sign a typo?

Yeah. Fixed.

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 13 of 16 files reviewed, all discussions resolved (waiting on @martinmr)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 16 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codexnull codexnull merged commit 3fb6da2 into master Feb 20, 2019
@codexnull codexnull deleted the javier/issue3011_ignore_uids_on_import branch March 1, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants