-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3011: ignore uids on import #3045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also resolve the conflicts?
Reviewed 16 of 16 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @codexnull)
dgraph/cmd/live/run.go, line 102 at r1 (raw file):
flag.BoolP("use_compression", "C", false, "Enable compression on connection to alpha server") flag.Bool("new_uids", false, ""+
Is the plus sign a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Reviewable status: 13 of 16 files reviewed, 1 unresolved discussion (waiting on @martinmr)
dgraph/cmd/live/run.go, line 102 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
Is the plus sign a typo?
Yeah. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 16 files reviewed, all discussions resolved (waiting on @martinmr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 16 files at r1, 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Summary of changes:
Update bulk loader to preserve UIDs from load data by default to match live loader behavior.
Add --new_uids option to both live and bulk loaders to ignore UIDs in load data and assign new ones.
Fixes #3011.
This change is