-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error of empty block queries #3015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @srfrog)
query/query.go, line 2539 at r1 (raw file):
gq.Alias != "shortest" && !gq.IsEmpty) { return x.Errorf("Invalid query, no function used at root and no aggregation" + " or math variables found in the body.")
This looks good. I'd make this two sentences. "Invalid query. No function ... "
IIRC, there was a change that shows the line/column number of the error in question. This won't have that, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai)
query/query.go, line 2539 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
This looks good. I'd make this two sentences. "Invalid query. No function ... "
IIRC, there was a change that shows the line/column number of the error in question. This won't have that, right?
No it wont
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from my side, once @danielmai 's comment is addressed and he gives an lgtm.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
query/query.go, line 2539 at r1 (raw file):
Previously, srfrog (Gus) wrote…
No it wont
* query/query.go: improve error of empty block queries * query/query.go: Changed error into two sentences
Closes #3006
This change is