Show total weight of path in shortest path algorithm. #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a field _totalWeight_ to the first node of each path showing the total weight of the path.
golangcibot
reviewed
Jan 30, 2019
manishrjain
reviewed
Jan 30, 2019
There was a problem hiding this comment.
Needs simplification.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @codexnull and @golangcibot)
martinmr
commented
Jan 30, 2019
There was a problem hiding this comment.
- Removed pathSource field
- Move the weight out of the params and into the subgraph itself
- Renamed field to weight
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @codexnull and @golangcibot)
manishrjain
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot and @martinmr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a field totalWeight to the first node of each path
showing the total weight of the path.
Addresses #2127
This change is