-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename lru cache metrics with a unified "dgraph_lru" prefix. #2714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai)
wiki/content/deploy/index.md, line 1430 at r1 (raw file):
The LRU cache metrics let you track on how well the posting list cache is being used. You can track `dgraph_lru_capacity_bytes`, `dgraph_lru_evicted_total`, and `dgraph_max_list_bytes` (see the [Data Metrics]({{< relref "#data-metrics" >}})) to determine if the cache size should be adjusted. A high number of evictions can indicate a large posting list that repeatedly is inserted and evicted from cache due to insufficient sizing. The LRU cache size can be tuned with the option `--lru_mb`.
100/80 chars.
x/metrics.go, line 69 at r1 (raw file):
BytesRead = expvar.NewInt("dgraph_read_bytes_total") BytesWrite = expvar.NewInt("dgraph_written_bytes_total") EvictedPls = expvar.NewInt("dgraph_lru_evicted_total")
LcacheEvicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @manishrjain)
wiki/content/deploy/index.md, line 1430 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
100/80 chars.
Done.
x/metrics.go, line 69 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
LcacheEvicts
Done.
…nc#2714) * Rename lru cache metrics with a "dgraph_lru" prefix. * Rename dgraph_evicted_lists_total to dgraph_lru_evicted_total. * docs: Update metrics section for `dgraph_lru` prefixed metrics. * Rename EvictedPls variable to LcacheEvicts for consistency with other Lcache vars. * Add TODO about moving away from Prometheus's expvar collector. * Reflow metrics docs to 100-columns.
This change is