Adding auth token support #2692
Conversation
|
|
dgraph/cmd/live/run.go
Outdated
| @@ -22,6 +22,7 @@ import ( | |||
| "compress/gzip" | |||
| "context" | |||
| "fmt" | |||
| "google.golang.org/grpc/metadata" | |||
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @manishrjain and @gitlw)
dgraph/cmd/live/run.go, line 25 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
File is not
goimports-ed
Move this to the next group.
dgraph/cmd/live/run.go, line 99 at r1 (raw file):
"Ignores conflicts on index keys during transaction") flag.StringP("auth_token", "a", "", "The auth token that is required when a schema file is provided(through the --schema option), " +
100 char limit. And reduce the explanation to a one liner.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @golangcibot)
dgraph/cmd/live/run.go, line 25 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Move this to the next group.
Done.
dgraph/cmd/live/run.go, line 99 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
100 char limit. And reduce the explanation to a one liner.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot)
Performed testing using the following steps: 1. The alpha server is started with the --auth_token option 2.a The live loader command is run _without_ any change of schema through the --schema option, then the --auth_token option is _not_ required, i.e. the rdf file can still be processed successfully without the --auth_token option 2.b The live loader command is run _with_ a schema change through the --schema option, then the --auth_token option _must_ be provided, otherwise the Alter gRPC call fails with an error complaining about missing the auth token
Performed testing using the following steps:
2.a The live loader command is run without any change of schema through the --schema option, then the --auth_token option is not required, i.e. the rdf file can still be processed successfully without the --auth_token option
2.b The live loader command is run with a schema change through the --schema option, then the --auth_token option must be provided, otherwise the Alter gRPC call fails with an error complaining about missing the auth token
This change is