Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring parse errors in bulk loader #2599

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Add support for ignoring parse errors in bulk loader #2599

merged 1 commit into from
Sep 20, 2018

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Sep 15, 2018

By default, bulk loader fails when it is unable to parse
RDF lines. This behaviour can be changed by providing a
command line flag (--ignore_error) and the bulk loader
would ignore the parse errors. The progress status shows
the number of such errors to keep track of them.

The progress status now also prints the file that the bulk
loader is processing along with the count of files.

Signed-off-by: Aman Mangal [email protected]


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2018

CLA assistant check
All committers have signed the CLA.

By default, bulk loader fails when it is unable to parse
RDF lines. This behaviour can be changed by providing a
command line flag (--ignore_error) and the bulk loader
would ignore the parse errors. The progress status shows
the number of such errors to keep track of them.

The progress status now also prints the file that the bulk
loader is processing along with the count of files.

Signed-off-by: Aman Mangal <[email protected]>
@mangalaman93
Copy link
Member Author

The output now looks like -

MAP 01h22m35s rdf_count:2.797G err_count:35.84k rdf_speed:564.4k/sec edge_count:7.186G edge_speed:1.450M/sec
MAP 01h22m36s rdf_count:2.797G err_count:35.85k rdf_speed:564.4k/sec edge_count:7.187G edge_speed:1.450M/sec
processing file (201 out of 6186): /dgraph1/rdf/part-05574-9b4506f3-5b0d-402d-a471-a63ae01b6ec6.rdf.gz
MAP 01h22m37s rdf_count:2.798G err_count:35.88k rdf_speed:564.5k/sec edge_count:7.190G edge_speed:1.450M/sec

@manishrjain
Copy link
Contributor

Thanks for the PR!

@manishrjain manishrjain merged commit 10ab0bc into hypermodeinc:master Sep 20, 2018
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
By default, bulk loader fails when it is unable to parse
RDF lines. This behaviour can be changed by providing a
command line flag (--ignore_error) and the bulk loader
would ignore the parse errors. The progress status shows
the number of such errors to keep track of them.

The progress status now also prints the file that the bulk
loader is processing along with the count of files.

Signed-off-by: Aman Mangal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants