Make has function correct w.r.t. transactions #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
added a commit
that referenced
this pull request
Oct 26, 2018
Fix a bug caused by #2585, where I mistook reverse to mean reverse iteration, when it actually meant reverse index. Fixed it to its original meaning.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Generate the full posting list based on the read timestamp, so we can determine if it is empty or not. If empty, then has should not pick up the UID. Similarly, use Btree to pick up posting lists from memory, also considering whether they have a valid posting keeping transactional properties intact. This fixes hypermodeinc#2574.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Fix a bug caused by hypermodeinc#2585, where I mistook reverse to mean reverse iteration, when it actually meant reverse index. Fixed it to its original meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the full posting list based on the read timestamp, so we can determine if it is empty or not. If empty, then has should not pick up the UID. Similarly, use Btree to pick up posting lists from memory, also considering whether they have a valid posting keeping transactional properties intact.
This fixes #2574.
This change is