All Oracle delta streams are applied via proposals. #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
We should stop having leaders and followers receive transaction status updates from Zero directly and apply them to their state. This causes multiple race conditions and the behavior becomes indeterministic with edge cases. Instead, we have the leaders receive the updates, and propose them to their corresponding group. Proposals flow through Raft and get applied via `Node.Run` in a serial manner. - Only print connection failure once, not every run. - Directly propose OracleDelta, instead of proposing one TxnContext per entry in OracleDelta. - Batch up multiple OracleDelta receives from Zero into one with smart batching into one proposal to the group. This would amortize the cost of proposals. - Remove unnecessary trace: "In run mutation"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should stop having leaders and followers receive transaction status updates from Zero directly and apply them to their state. This causes multiple race conditions and the behavior becomes indeterministic with edge cases. Instead, we have the leaders receive the updates, and propose them to their corresponding group. Proposals flow through Raft and get applied via
Node.Runin a serial manner.This change is