Various bug fixes #2457
Merged
Various bug fixes #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble list during iteration.
…any positive impact though. Still seeing the deadlocks.
…hing their destination.
…hey would need to be reproposed. Repropose messages after a timeout.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Bug Fixes: - Fixed a recently introduced bug in posting list, which caused persisted postings to be skipped. - Fix a long-standing bug, where we were dropping messages if `n.messages` channel was full. That caused loss of `MsgProp` messages, which had to be retried. There are other ways messages could be dropped, but doing it here was unnecessary. Cleanup: - Moved all tests to use docker-compose. test.sh now runs after running a 3-node cluster of Dgraph alphas. - Added an internal retry mechanism for dropped proposals in both server and Zero. - Moved random number generator to the common conn/node.go. - Moved common Dgraph flags to RootCmd. - Allowed Zero to expose its trace. - All server package unit tests now use Docker-based Dgraph cluster, instead of spawning their own Dgraph instances. - Query tests still work with their own Zero server. - Upgrade Raft library. - Improve tracking for proposal contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes:
n.messageschannel was full. That caused loss ofMsgPropmessages, which had to be retried. There are other ways messages could be dropped, but doing it here was unnecessary.Cleanup:
This change is