Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in snapshot move #2440

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Fix bugs in snapshot move #2440

merged 3 commits into from
Jun 13, 2018

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Jun 13, 2018 •
edited
Loading

  • Fix a bug with snapshot move, due to which the move would block forever. In particular, if a key-value didn't have a Version, then txn.CommitAt failed and didn't ever call wg.Done(). This caused wg.Wait() to block forever, hence keep the snapshot retrieval stuck forever.
  • Fix a nil pointer deference issue in pool.shutdown.

This PR fixes #2410 .

Potential improvement:

  • Make the predicate move concurrent, so we can quickly transfer large amounts of data in a short span of time. This can be useful in large data sets.

This change is Reviewable

@manishrjain manishrjain merged commit 78f457e into master Jun 13, 2018
@manishrjain manishrjain deleted the mrjn/moves branch June 13, 2018 02:22
@manishrjain manishrjain mentioned this pull request Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dgraph servers crashing after removing then re-adding a node
1 participant
@manishrjain