Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Mrjn/fix 2321 #2401

Merged
merged 8 commits into from
May 23, 2018
Merged

[WIP] Mrjn/fix 2321 #2401

merged 8 commits into from
May 23, 2018

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented May 18, 2018 •
edited
Loading

This change is Reviewable

@manishrjain
Various changes to fix 2321
ff6b414
@manishrjain
Some more printfs
42e19f9
@manishrjain
Merge branch 'master' into mrjn/fix-2321
f08a1a4
@manishrjain
Ability to correctly distinguish float from int. (#2398)
4177018 
With JSON mutations, we previously couldn't distinguish an int from float, using the standard json.Unmarshal. Now, we use a json.Decoder, with `UseNumber`, which allows us to correctly distinguish int from float.

This fixes #2377 and #2378 .
@manishrjain
Explain how iteration in export works.
64703a1
@manishrjain
merge with master
9964df4
@manishrjain
Rename dummy to _dummy_
d76c35e
@manishrjain
Small clarification.
3478abb
@manishrjain manishrjain merged commit d907674 into master May 23, 2018
@manishrjain manishrjain deleted the mrjn/fix-2321 branch May 23, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manishrjain