chore: apply go vet improvements

Author: mangalaman93

algo/packed_test.go

@@ -42,13 +42,6 @@ func TestMergeSorted1Packed(t *testing.T) {
 	require.Equal(t, []uint64{55}, codec.Decode(MergeSortedPacked(input), 0))
 }
 
-func printPack(t *testing.T, pack *pb.UidPack) {
-	for _, block := range pack.Blocks {
-		t.Logf("[%x]Block base: %d. Num uids: %d. Deltas: %x\n",
-			pack.AllocRef, block.Base, block.NumUids, block.Deltas)
-	}
-}
-
 func TestMergeSorted2Packed(t *testing.T) {
 	input := []*pb.UidPack{
 		newUidPack([]uint64{1, 3, 6, 8, 10}),

compose/compose.go

@@ -245,7 +245,7 @@ func getZero(idx int, raft string) service {
 		svc.Command += fmt.Sprintf(" --vmodule=%s", opts.Vmodule)
 	}
 	if idx == 1 {
-		svc.Command += fmt.Sprintf(" --bindall")
+		svc.Command += " --bindall"
 	} else {
 		svc.Command += fmt.Sprintf(" --peer=%s:%d", name(basename, 1), basePort)
 	}
@@ -734,9 +734,9 @@ func main() {
 
 	doc := fmt.Sprintf("# Auto-generated with: %v\n#\n", os.Args)
 	if opts.UserOwnership {
-		doc += fmt.Sprint("# NOTE: Env var UID must be exported by the shell\n#\n")
+		doc += "# NOTE: Env var UID must be exported by the shell\n#\n"
 	}
-	doc += fmt.Sprintf("%s", yml)
+	doc += string(yml)
 	if opts.OutFile == "-" {
 		x.Check2(fmt.Printf("%s", doc))
 	} else {

contrib/integration/mutates/main.go

@@ -107,7 +107,7 @@ func testInsert3Quads(ctx context.Context, c *dgo.Dgraph) {
 
 func testQuery3Quads(ctx context.Context, c *dgo.Dgraph) {
 	txn := c.NewTxn()
-	q := fmt.Sprint(`{ me(func: uid(200, 300, 400)) { name }}`)
+	q := `{ me(func: uid(200, 300, 400)) { name }}`
 	resp, err := txn.Query(ctx, q)
 	if err != nil {
 		log.Fatalf("Error while running query: %v\n", err)

contrib/teamcity/README.md

@@ -34,11 +34,6 @@ import (
 	"github.com/dgraph-io/ristretto/z"
 )
 
-type syncMark struct {
-	index uint64
-	ts    uint64
-}
-
 // Oracle stores and manages the transaction state and conflict detection.
 type Oracle struct {
 	x.SafeMutex

contrib/teamcity/test_stats.go

@@ -91,7 +91,7 @@ func (s *Server) MoveTablet(ctx context.Context, req *pb.MoveTabletRequest) (*pb
 	}
 	if !isKnown {
 		return &pb.Status{Code: 1, Msg: x.ErrorInvalidRequest},
-			fmt.Errorf("Group: [%d] is not a known group.", req.DstGroup)
+			fmt.Errorf("group: [%d] is not a known group", req.DstGroup)
 	}
 
 	tablet := x.NamespaceAttr(req.Namespace, req.Tablet)

dgraph/cmd/zero/oracle.go

@@ -71,7 +71,7 @@ func TestIdBump(t *testing.T) {
 	bumpTo := res.GetEndId() + 100000
 
 	// Bump the lease to (last result + 100000).
-	res, err = zc.AssignIds(ctx, &pb.Num{Val: bumpTo, Type: pb.Num_UID, Bump: true})
+	_, err = zc.AssignIds(ctx, &pb.Num{Val: bumpTo, Type: pb.Num_UID, Bump: true})
 	require.NoError(t, err)
 
 	// Next assignemnt's startId should be greater than bumpTo.
@@ -81,6 +81,6 @@ func TestIdBump(t *testing.T) {
 	require.Equal(t, uint64(10), res.GetEndId()-res.GetStartId()+1)
 
 	// If bump request is less than maxLease, then it should result in no-op.
-	res, err = zc.AssignIds(ctx, &pb.Num{Val: 10, Type: pb.Num_UID, Bump: true})
+	_, err = zc.AssignIds(ctx, &pb.Num{Val: 10, Type: pb.Num_UID, Bump: true})
 	require.Contains(t, err.Error(), "Nothing to be leased")
 }

dgraph/cmd/zero/tablet.go

@@ -37,7 +37,6 @@ import (
 	"github.com/pkg/errors"
 	ostats "go.opencensus.io/stats"
 	"go.opencensus.io/tag"
-	"go.opencensus.io/trace"
 	otrace "go.opencensus.io/trace"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/codes"
@@ -255,8 +254,9 @@ func validateAlterOperation(ctx context.Context, op *api.Operation) error {
 
 // parseSchemaFromAlterOperation parses the string schema given in input operation to a Go
 // struct, and performs some checks to make sure that the schema is valid.
-func parseSchemaFromAlterOperation(ctx context.Context, op *api.Operation) (*schema.ParsedSchema,
-	error) {
+func parseSchemaFromAlterOperation(ctx context.Context, op *api.Operation) (
+	*schema.ParsedSchema, error) {
+
 	// If a background task is already running, we should reject all the new alter requests.
 	if schema.State().IndexingInProgress() {
 		return nil, errIndexingInProgress
@@ -980,7 +980,7 @@ type queryContext struct {
 	// l stores latency numbers
 	latency *query.Latency
 	// span stores a opencensus span used throughout the query processing
-	span *trace.Span
+	span *otrace.Span
 	// graphql indicates whether the given request is from graphql admin or not.
 	graphql bool
 	// gqlField stores the GraphQL field for which the query is being processed.
@@ -1228,7 +1228,7 @@ func (s *Server) doQuery(ctx context.Context, req *Request) (resp *api.Response,
 		return nil, errors.Errorf("empty request")
 	}
 
-	span.AddAttributes(trace.StringAttribute("Query", req.req.Query))
+	span.AddAttributes(otrace.StringAttribute("Query", req.req.Query))
 	span.Annotatef(nil, "Request received: %v", req.req)
 	if isQuery {
 		ostats.Record(ctx, x.PendingQueries.M(1), x.NumQueries.M(1))