add todos and fix logs

Author: mangalaman93

posting/index.go

@@ -531,7 +531,7 @@ func (r *rebuilder) Run(ctx context.Context) error {
 		WithCompression(options.None).
 		WithEventLogging(false).
 		WithLogRotatesToFlush(10).
-		WithMaxCacheSize(50)
+		WithMaxCacheSize(50) // TODO(Aman): Disable cache altogether
 	tmpDB, err := badger.OpenManaged(dbOpts)
 	if err != nil {
 		return errors.Wrap(err, "error opening temp badger for reindexing")
@@ -546,9 +546,15 @@ func (r *rebuilder) Run(ctx context.Context) error {
 	// We set it to 1 in case there are no keys found and NewStreamAt is called with ts=0.
 	var counter uint64 = 1
 
+	// Todo(Aman): Replace TxnWriter with WriteBatch. While we do that we should ensure that
+	// WriteBatch has a mechanism for throttling. Also, find other places where TxnWriter
+	// could be replaced with WriteBatch in the code
+	// Todo(Aman): Replace TxnWriter with WriteBatch. While we do that we should ensure that
+	// WriteBatch has a mechanism for throttling. Also, find other places where TxnWriter
+	// could be replaced with WriteBatch in the code. 
 	tmpWriter := NewTxnWriter(tmpDB)
 	stream := pstore.NewStreamAt(r.startTs)
-	stream.LogPrefix = fmt.Sprintf("Rebuilding index for predicate %s:", r.attr)
+	stream.LogPrefix = fmt.Sprintf("Rebuilding index for predicate %s (1/2):", r.attr)
 	stream.Prefix = r.prefix
 	stream.KeyToList = func(key []byte, itr *badger.Iterator) (*bpb.KVList, error) {
 		// We should return quickly if the context is no longer valid.
@@ -619,7 +625,7 @@ func (r *rebuilder) Run(ctx context.Context) error {
 
 	writer := NewTxnWriter(pstore)
 	tmpStream := tmpDB.NewStreamAt(counter)
-	tmpStream.LogPrefix = fmt.Sprintf("Rebuilding index for predicate %s:", r.attr)
+	tmpStream.LogPrefix = fmt.Sprintf("Rebuilding index for predicate %s (2/2):", r.attr)
 	tmpStream.KeyToList = func(key []byte, itr *badger.Iterator) (*bpb.KVList, error) {
 		l, err := ReadPostingList(key, itr)
 		if err != nil {