Export backup loader interface and rename Load method. #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in the load method will be moved to Dgraph so that it can support converting keys and values from a different format. To compensate, the loader interface has been exported as KVLoader.
Also add a not telling users to use the KVLoader if more complex logic is needed to restore a backup.
martinmr
changed the title
ashish-goswami
approved these changes
Jun 27, 2019
manishrjain
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Don't change the APIs in Badger. Rest is good.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
backup.go, line 199 at r1 (raw file):
// DB.DefaultLoad() should be called on a database that is not running any other // concurrent transactions while it is running. func (db *DB) DefaultLoad(r io.Reader, maxPendingWrites int) error {
Keep the name same.
martinmr
commented
Jul 1, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
backup.go, line 199 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Keep the name same.
Done.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
The logic in the load method will be copied to Dgraph so that it can support converting keys and values from a different format. To allow this, the loader interface has been exported as KVLoader. Also add a note telling users to use the KVLoader if more complex logic is needed to restore a backup. (cherry picked from commit 50ccc86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loader type has been exported as KVLoader. This will allow Dgraph to implement
custom restore logic (i.e change the format of the keys and values before writing the data).
Originally I deleted the Load method but it's still required by the "badger restore" command.
To indicate that this method just performs a very basic restore, I renamed the method to
DefaultLoad and indicated that more complex restore logic should be implemented using
the KVLoader instead.
This change is