Rename Fill to Write Benchmark Tool #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Single routine for printing stats * Get Keys via stream framework
* Add sample-size and keys-only size * Fix code to have exactly sample no of keys * Wrap returned errors * Change function names * Add comments
* Optimise stream to read only keys while sampling * Addres review comments
Idea is to have hierarchy for benchmark commands.
* Add license * Change default go routine to 16 * Make read only optional * Make loading mode optional * Change reader and printer routine names * Modify KeyToList func of StreamWriter * Shuffle keys before sampling
* Change file name fill to write_bench.go * Add code to print writestats
* Remove check "G404: Use of weak random number generator (math/rand instead of crypto/rand) (from gosec)" from gas linter
mangalaman93
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
.golangci.yml, line 26 at r1 (raw file):
- linters: - gosec text: "G404: "
newline missing
badger/cmd/write_bench.go, line 31 at r1 (raw file):
"github.com/dgraph-io/badger/pb" "github.com/dgraph-io/badger/y" humanize "github.com/dustin/go-humanize"
separate imports
jarifibrahim
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR(#859) for above changes was raised against a different branch. Raising it against master again. I have merged latest changes from master in this branch.
This change is