Cleaned some code

[mariecurried]

Made some changes to improve the quality of the code and comments:

• Only generate the defer code to release the lock on the value directory if it is different from the main directory
• Removed a period from ErrValueThreshold to keep it consistent with the other errors
• Removed an unused image
• Make explicit that if the directory or the value directory don't exist, they will try to be created
• Remove an impossible case from a switch
• Replace ts += 1 for t++

---

This change is 

[martinmr]

Reviewed 3 of 6 files at r1.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @marigonzes)

---

options.go, line 35 at r1 (raw file):

	// Directory to store the data in. If it doesn't exist, it will
	// try to be created for you.

Rephrase this sentence to something like "If it doesn't exist, Badger will try to create it for you". The current phrasing makes it sound like the directory will create itself.

Same for the sentence below.

---

txn.go, line 624 at r1 (raw file):

		err := cb.commit()
		cb.user(err)
	case cb.user == nil:

I am not sure if this should be removed but it should be the second case (right below "case cb == nil").

[mariecurried]

Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @martinmr)

---

options.go, line 35 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

	// Directory to store the data in. If it doesn't exist, it will
	// try to be created for you.

Rephrase this sentence to something like "If it doesn't exist, Badger will try to create it for you". The current phrasing makes it sound like the directory will create itself.

Same for the sentence below.

Done.

---

txn.go, line 624 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

I am not sure if this should be removed but it should be the second case (right below "case cb == nil").

Done. Initially I removed it, because I noticed it was possible for it to be nil in the lines above. Should have just move it in the first place.

[martinmr]

Reviewable status: 3 of 6 files reviewed, all discussions resolved

[martinmr]

Approved and merged. Thanks for your PR.

[manishrjain]

Thanks for your PR. But, why delete the sketch? Wasn't hurting anybody.

[mariecurried]

@manishrjain, now I feel bad for the little badger 😢
Can you bring it back?