Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in L0StallMs variable #1605

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fix race condition in L0StallMs variable #1605

merged 1 commit into from
Nov 25, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Nov 25, 2020 •
edited
Loading

This fixes two issues

  • Atomic variable was not being accessed correctly
  • Atomic variable should be first member of the struct to ensure proper alignment. Failure to do so will cause a segmentation fault.

Fixes DGRAPH-2773

This change is Reviewable

ajeetdsouza
ajeetdsouza reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ajeetdsouza ajeetdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)

ajeetdsouza
ajeetdsouza approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ajeetdsouza ajeetdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@jarifibrahim jarifibrahim merged commit 925e15b into master Nov 25, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/stall-race branch November 25, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajeetdsouza ajeetdsouza ajeetdsouza approved these changes

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarifibrahim @ajeetdsouza @ahsanbarkati