-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set datakey for first table in stream writer #1054
Conversation
If encryption is enabled on a DB and stream writer is used then the first file SST would not be encrypted, only the SSTs after the first one would be encrypted. This PR fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ A review job has been created and sent to the PullRequest network.
@jarifibrahim you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @ashish-goswami, @golangcibot, and @manishrjain)
stream_writer.go, line 128 at r2 (raw file):
} for streamID, req := range streamReqs {
This was changed to make golint happy. See #1054 (comment)
stream_writer.go, line 216 at r2 (raw file):
} func (sw *StreamWriter) newWriter(streamID uint32) (*sortedWriter, error) {
This was changed to make golint happy. See #1054 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @ashish-goswami, @golangcibot, @jarifibrahim, and @manishrjain)
stream_writer.go, line 134 at r2 (raw file):
writer, err = sw.newWriter(streamID) if err != nil { return errors.Wrapf(err, "failed to create writer with ID %d", streamID)
I think error can be wrapped only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @ashish-goswami, @golangcibot, and @manishrjain)
stream_writer.go, line 134 at r2 (raw file):
Previously, ashish-goswami (Ashish Goswami) wrote…
I think error can be wrapped only once.
Done. See newWriter
method. It no longer wraps the error.
Merging this PR since it's a simple change and doesn't require @manishrjain's review. |
If encryption is enabled on a DB and stream writer is used then the
first file SST would not be encrypted, only the SSTs after the first one
would be encrypted. This PR fixes it.
This change is