Drop diagnostics on closing the file #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chioni16
force-pushed
the
drop-diagnostics-on-close
branch
2 times, most recently
from
a581181
to
b41065c
Compare
Signed-off-by: Govardhan G D <[email protected]>
chioni16
force-pushed
the
drop-diagnostics-on-close
branch
from
b41065c
to
2b928d4
Compare
seanyoung
reviewed
Jun 26, 2023
| @@ -1179,6 +1179,8 @@ impl LanguageServer for SolangServer { | |||
| if let Ok(path) = uri.to_file_path() { | |||
| self.files.lock().await.remove(&path); | |||
| } | |||
|
|
|||
| self.client.publish_diagnostics(uri, vec![], None).await; | |||
There was a problem hiding this comment.
Wonderful!
Again, this could do with a test
There was a problem hiding this comment.
I tried writing a test using the vscode typescript API to open and close files.
I am using vscode.commands.executeCommand('workbench.action.closeActiveEditor') to close the open tab. But this doesn't seem to emit the didClose event which is what the language server listens for.
I tried registering a listener for this event in javascript as well. But, this listener did not run either.
But manually closing the files works every time and the old diagnostics disappear when this happens.
xermicus
approved these changes
Jun 26, 2023
|
Please, run |
Signed-off-by: Govardhan G D <[email protected]>
chioni16
force-pushed
the
drop-diagnostics-on-close
branch
from
c1b55b3
to
b8f1ac3
Compare
seanyoung
approved these changes
Jul 1, 2023
LucasSte
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing a file in VS code, all the warnings and errors remain in the list of problems. This removes all diagnostics pertaining to the close file.